Conversation
|
|
||
| ## Outcomes | ||
|
|
||
| * General agreement that `t.skip()`'s behaviour is wrong (likely an accident/bug/mistake, which the docs seem to support). |
There was a problem hiding this comment.
I've just checked the rest of the documentation, and the behavior is definitely intended:
https://nodejs.org/docs/v24.13.0/api/test.html#contextskipmessage.
When checking other test runners, like Mocha, this behavior also exists (e.g. https://mochajs.org/declaring/inclusive-tests/#_top).
Given that this behavior is "by design" and aligned with other test runners,IMHO , it's just a matter of personal preference...and I don't think it's enough to justify a major breaking change
P.S.: the same is true for Vitest as well (https://vitest.dev/guide/test-context.html#test-context)
There was a problem hiding this comment.
Ah, interesting. Thanks for checking!
If it's actually fairly common, then sure, it's already there. Kinda weird, but some people like liquorice too 🤷♂️
There was a problem hiding this comment.
We might want to understand how common it is, but I'm not sure that, without a standard, it makes sense to compare different tools...
cc @ljharb
There was a problem hiding this comment.
If these runners all have the API, then that’s a very different story, but it still seems weird to me given the tap-like API the test runner has - which leads into the design philosophy discussion.
|
|
||
| ## Outcomes | ||
|
|
||
| * General agreement that `t.skip()`'s behaviour is wrong (likely an accident/bug/mistake, which the docs seem to support). |
There was a problem hiding this comment.
| * General agreement that `t.skip()`'s behaviour is wrong (likely an accident/bug/mistake, which the docs seem to support). | |
| * ~Initially general agreement that `t.skip()`'s behaviour is wrong (likely an accident/bug/mistake, which the docs seem to support).~ | |
| * Further investigation shows this behaviour | |
| * exists in others (including [mocha](https://mochajs.org/declaring/inclusive-tests/#_top)) | |
| * was intended: https://nodejs.org/docs/v24.13.0/api/test.html#contextskipmessage |
3 participants
Closes #14